-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report non client-safe errors through Laravel's ExceptionHandler
#1303
#1303
Conversation
I am not sure which errors should be reported by default and how we can differentiate between them. It does seem unnecessary to report syntax errors in client queries and validation errors. On the other hand, it might be useful to report errors where someone might try to attack the server, such as authorization errors or when somebody triggers the complexity limitation repeatedly. |
Could a possible option be to only report errors that are not client safe? If they're client safe we can assume the client should be able to handle them, however that would mean that complexity errors for example are not reported since they're considered client safe. But there might not be a good criteria on what to do or not report, so going for client safe could be a safe one and if you need more you can add your own error handler reporting those (or replace this reporting handler altogether with one with custom logic). |
ExceptionHandler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change 👍
ExceptionHandler
ExceptionHandler
#1303
Resolves #1026
Changes
Propagate the reporting of error that occur within GraphQL execution to Laravel's default
ExceptionHandler
.Thanks to @olivernybroe for this idea in #1026 (comment)
Breaking changes
No